Recentf cleanup logs a lot of error messages

[rahguzar]

What happened?

Everytime recentf cleanup happens, in addition to the usual

Cleaning up the recentf list...

I also see a lot of messages of the form

Wrong type argument: "Wrong type argument", "tramp-file-name FILENAME"

I think it started happening quite recently.

What did you expect to happen?

Recentf cleanup to happen without errors.

Attempt to diagnose

I think the problem is with doom--recentf-file-truename-fn specifically with the use of tramp-file-name-localname in it. I think it should instead be tramp-file-local-name or file-local-name.

[Jeff_Kowalski]

I can confirm the same behavior here, with

GNU Emacs     v28.1            nil
Doom core     v3.0.0-pre       HEAD -> master, origin/master, origin/HEAD 9d4d5b75 2022-10-31 16:18:16 +0100
Doom modules  v22.10.0-pre     HEAD -> master, origin/master, origin/HEAD 9d4d5b75 2022-10-31 16:18:16 +0100

[torgeir]

I’m also seeing this when I am connecting to a host over tramp to use find-file

GNU Emacs     v28.3            nil
Doom core     v3.0.0-pre       grafted, HEAD -> master, origin/master, origin/HEAD 042fe0c4 2023-04-12 15:09:23 -0400
Doom modules  v23.03.0-pre     grafted, HEAD -> master, origin/master, origin/HEAD 042fe0c4 2023-04-12 15:09:23 -0400

[rahguzar]

Putting this in your config.el should fix the issue,

(after! tramp (advice-add 'doom--recentf-file-truename-fn :override
                          (defun my-recent-truename (file &rest _args)
                            (if (or (not (file-remote-p file)) (equal "sudo" (file-remote-p file 'method)))
                                (abbreviate-file-name (file-truename (tramp-file-local-name file)))
                              file))))