This topic will cover the experimental work done on :completion corfu.
Corfu is a childframe-based completion selection package, like company or auto-complete do. Associated with Cape, it might easily reach feature-parity with Company while having less legacy code and using more of the recent Emacs changes to make package code simpler.
Waiting on Henrik to have a status on whether he wants to steer/control the module direction. But meanwhile, you can discuss my draft if you want to take a peek at it.
I’ve just copied this module to my config and I’m using it now. I’ve been wanting corfu for a few weeks now. I tested it a little bit last night but found that ‘tabbing’ was a little bit jarring compared to how the company module works in doom. Of course it’s trivial to remap in my config.el, but may not be consistent with the rest of doom.
I’ve been testing this new capf with this module code, and am getting odd behavior, which the author of that package does not see with his non-doom corfu install.
I get the candidate list when in an org buffer, but when I try to select a candidate with RET, it adds a newline to the buffer, rather than inserts the candidate (well, really the result of the :exit-function run on the candidate).
I do not see the same behavior in other major modes (for example, lisp).
Is it possible there’s something in this code that could cause that behavior? Any suggestions on narrowing it down?
I’ve been playing with this module a little bit while doing some eslisp stuff. I find that there is some conflict between doom’s :editor snippets and the TAB completion setup. For example, if I type (set then hit TAB for some corfu goodness, it auto-expands and wrecks the completion. For now I’ve just disabled snippets.
Mostly ignore the code in my last comment. On testing it only worked in elisp mode. I’m still using ‘C-n’ and ‘C-p’ for candidate selection, and ‘jk’ to exit completions.
Also, I think in the config.el of the corfu module, inside the (use-package! cape ... ) expression, we should be adding #'cape-file rather than #'cape-file-capf. This goes for all cape-* capfs in the above-mentioned expression. The latter was giving me errors. I don’t know if minad refactored or something.
I like it. Instead of waiting on Henrik, why not start a draft PR? That way, Henrik can have quick look and/or review comments whenever he wants, and the users get single point of reference on status and pull any new module-specific change?
Ended up solving this by advising +org/return as below, adjust as required
(defadvice! +corfu--org-return (orig) :around '+org/return
(if (and (featurep! :completion corfu) ;; omit if not using via a module
(>= corfu--index 0)) ;; translates to "there are candidates to select"
Did any of you install corfu-terminal ? It seems that straight doesn’t know of NonGNU ELPA and it seems to bite me because it tries to find a popon package even if I mention the whole rpoe URL for corfu-terminal