Listed below are all the changes that we will not accept, if submitted as part of a pull request. They are grouped by project and include an explanation. This list will change often, so please check it often.
If you believe your change is an exception, please discuss it with me on our Discord (in the #development channel) or here (in the #dev category).
All projects
| Where | Types of changes | Reason | Since |
|---|---|---|---|
LICENSE |
Any changes | [1] | 2022-02-16T23:00:00Z |
**/* |
Fewer than 3 trivial corrections per PR. This includes minor spelling, grammar, or syntax errors in docs, comments, or output messages that have no user-facing effect | [2] | 2022-03-18T23:00:00Z |
doomemacs/doomemacs
| Where | Types of changes | Reason | Since |
|---|---|---|---|
docs/*.org |
Any changes | [3] | 2021-11-28T23:00:00Z |
modules/**/* |
Any changes | [4] | 2022-10-21T22:00:00Z |
README.md |
Any changes | [5] | 2022-10-27T22:00:00Z |
doomemacs/modules
| Where | Types of changes | Reason | Since |
|---|---|---|---|
| :config default | Feature-gating keybinds | [6] | 2019-04-07T22:00:00Z |
| :editor format | Bumping format-all
|
[7] | 2020-12-31T23:00:00Z |
| :lang org | Bumping gnuplot
|
[8] | 2022-02-02T23:00:00Z |
doomemacs/contrib-modules
doomemacs/themes
There is nothing in this project’s do-not-PR list at this time.
doomemacs/snippets
There is nothing in this project’s do-not-PR list at this time.
-
Important changes, such as those to the license of the project, should be discussed beforehand and ultimately enacted by me, not anyone else. ↩︎
-
Every PR—however trivial—costs time to process. This cost is not justified on trivial PRs like these, so I discourage them, unless either:
- The mistake causes confusion (e.g. an ambiguous misspelling of a package, function, or shell command),
- The original passage is undecipherable,
- Or there are more than three separate corrections in your PR.
I suggest leaving a Github comment on the responsible commit or letting us know on Discord, instead. ↩︎
-
Our primary documentation is currently undergoing a hefty rewrite. ↩︎
-
As Doom nears its 3.0 release, I intend to move its module libraries out into two separate repos (one for official modules and one for community-maintained ones). This will be happening very soon (within the next 2-3 weeks). To make this transition easier, I won’t be accepting PRs to our modules for the time being, but feel free to open issues or let me know on Discourse/Discord. ↩︎
-
The readme will be rewritten once 3.0 is released, since the project will see a large number of important changes, so I won’t be accepting PRs to this file for the time being. ↩︎
-
That is to say, I won’t accept PRs that wrap keybinds in
(:when (modulep! ...) ...)checks. I explain why in #1312#issuecomment-480650364. ↩︎ -
The :lang format module is pending a rewrite—where this package will be replaced. Also, later commits of this package have introduced breaking changes that are incompatible with the current module. ↩︎
-
The latest commit of gnuplot throws a recursive
requireerror when lazy-loaded (see #6080). ↩︎