New :completion corfu module

Development modules
#4

I’ve been testing this new capf with this module code, and am getting odd behavior, which the author of that package does not see with his non-doom corfu install.

I get the candidate list when in an org buffer, but when I try to select a candidate with RET, it adds a newline to the buffer, rather than inserts the candidate (well, really the result of the :exit-function run on the candidate).

I do not see the same behavior in other major modes (for example, lisp).

Is it possible there’s something in this code that could cause that behavior? Any suggestions on narrowing it down?

1 Like
#5

Also re: testing.

I’ve been playing with this module a little bit while doing some eslisp stuff. I find that there is some conflict between doom’s :editor snippets and the TAB completion setup. For example, if I type (set then hit TAB for some corfu goodness, it auto-expands and wrecks the completion. For now I’ve just disabled snippets.

#6

Yes, that is the main outstanding issue in what I’ve done yet, it triggers me so so hard.

When I get time I’ll try to find out why

2 Likes
#7

So far, what I’ve done is remap:

  • corfu-next to C-j
  • corfu-previous to C-k
  • corfu-quit, to [evil-escape] so I can just jk out of the prompt

I think I’ll also disable TAB as a point of entry too. I think C-SPC may be more appropriate, if not auto-completion, which is how doom’s company is set to trigger.

I’ll edit this post to add the actual config when I’m at the computer next. EDIT: Here’s my remap expression. I don’t know if it’s idiomatic or not, please correct me.

(with-eval-after-load 'corfu
  (let ((map corfu-map))
    (define-key map [remap +default/newline] #'corfu-next)
    (define-key map [remap evil-insert-digraph] #'corfu-previous)
    (define-key map (kbd "jk") #'corfu-quit)))
#8

Mostly ignore the code in my last comment. On testing it only worked in elisp mode. I’m still using ‘C-n’ and ‘C-p’ for candidate selection, and ‘jk’ to exit completions.

Also, I think in the config.el of the corfu module, inside the (use-package! cape ... ) expression, we should be adding #'cape-file rather than #'cape-file-capf. This goes for all cape-* capfs in the above-mentioned expression. The latter was giving me errors. I don’t know if minad refactored or something.

#9

Didn’t test it yet, but there might be a better TUI version of corfu now

https://elpa.nongnu.org/nongnu/corfu-terminal.html

#10

Actually, I see the same thing when inserting an org block.

Can anyone else confirm this?

1 Like
#11

Just started using this, I’m much more satisfied with it than company.

#12

Can you elab? I haven’t really hit any annoyances with company, but maybe I just don’t know what I’m missing

#13

Faster, looks cleaner, more reliable completion for starters

#14

I like it. Instead of waiting on Henrik, why not start a draft PR? That way, Henrik can have quick look and/or review comments whenever he wants, and the users get single point of reference on status and pull any new module-specific change?

#15

I can confirm this, there’s some autoload behaviour going on with evil-org that forces RET to be the default behaviour no matter what.

Not sure how to resolve it honestly, @hlissner?

1 Like
#16

Ended up solving this by advising +org/return as below, adjust as required :slight_smile:

(defadvice! +corfu--org-return (orig) :around '+org/return
    (if (and (featurep! :completion corfu) ;; omit if not using via a module
             corfu-mode
             (>= corfu--index 0)) ;; translates to "there are candidates to select"
        (corfu-insert)
      (funcall orig)))
2 Likes
#17

Did any of you install corfu-terminal ? It seems that straight doesn’t know of NonGNU ELPA and it seems to bite me because it tries to find a popon package even if I mention the whole rpoe URL for corfu-terminal

FTR the tracking issue for NonGNU ELPA support in straight

#18

Yeah I had to manually add both as recipes because of them not being in a repo in straight

https://github.com/elken/doom/blob/1a92f7e8d272e62e99de6e2041dee4b105424fe1/modules/completion/corfu/packages.el#L13-L18

#19

It should be okay soon, the issue has been closed and straight can deal with NonGNU ELPA natively. It will needa bump of straight to pull the changes though

1 Like
#20

Does anyone have a quick tour or TLDR of stuff I should take for a spin when copying the module and trying it.

2 Likes
#21

Should we style this together and set defaults in the Doom module? Corfus own defaults are kind of underwhelming if you compare it to company.

Maybe set the styling according to the theme even? Like this:

  (custom-set-faces!
    `(corfu-current
      :background ,(doom-blend (doom-color 'blue) (doom-color 'bg-alt) 0.3)
      :extend t)))
#22

I’m experimenting with :completion corfu and I think that there are two keybindings missing. In insert state C-x C-f is bound to find-file, whereas in vim and :completion company it allow to complet the file’s name. So I think C-x C-f should be bound to cape-file in insert state. For same reason C-x C-o should be bound to corfu-next in insert state.

otherwise thank for work on this module !

#23

Is there interest in integrating prescient.el with Corfu to improve candidate sorting? It could be put behind a module flag like +prescient in the ivy module.

prescient.el provides a corfu-prescient package that should make integration easy. Its functionality overlaps with corfu-history, so that should be disabled if prescient.el is in use.